fix(runtime-core): optional props from Mixin/Extends are treated as r… #2048
+133
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Unfortunately, after merging #1883, I wasn't able to resolve the conflicts in a way that passes all the tests (specifically I couldn't get props with default from mixins to be made optional). Would you mind rebase your PR on top of master? Thanks! |
wonderful-panda
force-pushed
the
fix-2039
branch
from
dfba8a0
to
b3b9ec8
Compare
|
Thank you. Rebased and pushed now. BTW, ExtraPropTypes no longer needs second parameter ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…equired (#2039)