fix(compat): correctly merge lifecycle hooks when using Vue.extend (fix #3761) #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberAP
force-pushed
the
fix-vue-compat-extend-lifecycle-hooks
branch
from
e604ca7
to
b8bf9a1
Compare
CyberAP
changed the title
CyberAP
changed the title
CyberAP
force-pushed
the
fix-vue-compat-extend-lifecycle-hooks
branch
2 times, most recently
from
96f2522
to
79e5c6e
Compare
CyberAP
changed the title
CyberAP
force-pushed
the
fix-vue-compat-extend-lifecycle-hooks
branch
from
79e5c6e
to
9be82af
Compare
CyberAP
force-pushed
the
fix-vue-compat-extend-lifecycle-hooks
branch
from
9be82af
to
e52193d
Compare
CyberAP
changed the title
CyberAP
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this fix does introduce some performance overhead to the hot-path, I've tried to negate it with a
__VUE_COMPAT__check inrunLifecycleHook.Closes #3761