Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak when using computed is SSR mode #5208

Closed
levchak0910 opened this issue Jan 5, 2022 · 3 comments
Closed

Memory leak when using computed is SSR mode #5208

levchak0910 opened this issue Jan 5, 2022 · 3 comments
Labels
p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working

Comments

@levchak0910
Copy link

Version

3.2.26

Reproduction link

github.com

Steps to reproduce

Described is repository readme

What is expected?

Do not see memory leaks

What is actually happening?

Memory leaks


I report this issue here because this is reproducible in both vite and nuxt environments
If this is not an appropriate repo please tell me where I should report to

@LinusBorg
Copy link
Member

LinusBorg commented Jan 5, 2022

Edit: I misinterpreted the screenshot as I didn't see that doctor profiler setup thing initially. That might make my point here moot:

Can you clarify what you see as a memory leak here? I only see increased memory usage which is not a leak and could be perfectly explained by the fact that in one case you create hundreds (thousands?) of computed properties while in the other you simply don't.

A leak would be if you destroyed all of these Posts again and memory usage would not decrease to the same level.

@levchak0910
Copy link
Author

Updated reproduction description

@yyx990803 yyx990803 added p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working labels Jan 16, 2022
@levchak0910
Copy link
Author

@yyx990803 amazing, thanks for quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants