triggerRef not update for shallowRef when watching multiple values (Array argument)

[tangjinzhou]

Version

3.2.30

Reproduction link

sfc.vuejs.org/

Steps to reproduce

1、watch shallowRef by arr
2、triggerRef

What is expected?

trigger watch

What is actually happening?

not trigger watch

[edison1105]

as workaround:

watch(...[arr], ()=> {
  console.log('watch [arr] : arr change, but not trigger watch')
})

[LinusBorg]

Edit: I'm rather confused why the first one does work at all. It's a shallow ref.

Edit2: Nevermind I missed the whole point

[tangjinzhou]

triggerRef for shallowRef

[lidlanca]

workaround

its a bug.

core/packages/runtime-core/src/apiWatch.ts

Lines 213 to 219 in 9c304bf

	} else if (isArray(source)) {
	isMultiSource = true
	forceTrigger = source.some(isReactive)
	getter = () =>
	source.map(s => {
	if (isRef(s)) {
	return s.value

this might be a possible patch

    forceTrigger = source.some(isReactive)||source.some(isShallow)

[kuang-lingxi]

@LinusBorg hi! can i ask a question about watch implementation? why do we treat ref and shallow ref differently, when we use shallow ref, the callback function is forced to fire.I don't seem to see the corresponding instructions on the official documentation.

core/packages/runtime-core/src/apiWatch.ts

Lines 204 to 215 in 5898629

	let forceTrigger = false
	let isMultiSource = false
	if (isRef(source)) {
	getter = () => source.value
	forceTrigger = isShallow(source)
	} else if (isReactive(source)) {
	getter = () => source
	deep = true
	} else if (isArray(source)) {
	isMultiSource = true
	forceTrigger = source.some(isReactive)

core/packages/runtime-core/src/apiWatch.ts

Lines 307 to 311 in 5898629

	if (
	deep ||
	forceTrigger ||
	(isMultiSource
	? (newValue as any[]).some((v, i) =>

[edison1105]

@kuang-lingxi see #2231

[kuang-lingxi]

@kuang-lingxi see #2231

thanks reply!actually I saw this issue yesterday via git commit. In the previous implementation, the check was skipped by judging whether it was a ref. actually I don't really understand why ref skips the check.

or i change the question, what is the expected behavior of the watch function when it accepts ref/shallow ref/reactive object? Is there any documentation on this?