Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim and number modifiers exist in V-model at the same time, and the number modifier does not take effect #5839

Closed
hchlq opened this issue May 1, 2022 · 2 comments · Fixed by #5842
Closed

Trim and number modifiers exist in V-model at the same time, and the number modifier does not take effect #5839

hchlq opened this issue May 1, 2022 · 2 comments · Fixed by #5842
Labels
✨ feature request New feature or request

Comments

@hchlq
Copy link
Contributor

hchlq commented May 1, 2022 •
edited
Loading

Version

3.2.33

Reproduction link

sfc.vuejs.org/

Steps to reproduce

Both trim and number modifiers exist in V-model

What is expected?

number and trim modifiers exist at the same time, and number does take effect.

What is actually happening?

number and trim modifiers exist at the same time, and number does not take effect.

In runtime-dom/directives/vModel.ts, If the trim modifier exists, the number modifier does not take effect. Is there any reason for this?
image
@liulinboyi liulinboyi mentioned this issue May 1, 2022
Merged
@liulinboyi
Copy link
Member

Fix example

@hchlq
Copy link
Contributor Author

hchlq commented May 1, 2022

Fix example

Know how to solve it. There's no need for the official to raise the pull request without giving the result

@LinusBorg LinusBorg added the ✨ feature request New feature or request label May 2, 2022
@hchlq hchlq mentioned this issue May 2, 2022
Closed
liulinboyi added a commit to liulinboyi/core that referenced this issue May 2, 2022
@liulinboyi
fix(runtime-dom): add test for vuejs#5839
b002cee
yyx990803 pushed a commit that referenced this issue May 12, 2022
@liulinboyi
fix(v-model): fix case where .trim and .number modifiers are used tog…
71066b5 
…ether (#5842)

fix #5839
iwusong pushed a commit to iwusong/core that referenced this issue May 13, 2022
@liulinboyi @iwusong
fix(v-model): fix case where .trim and .number modifiers are used tog…
5eeef4a 
…ether (vuejs#5842)

fix vuejs#5839
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
✨ feature request New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@LinusBorg @liulinboyi @hchlq