Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(runtime-dom): add missing img attr loading #6160

Merged
merged 1 commit into from
Jul 10, 2023
Merged

types(runtime-dom): add missing img attr loading #6160

merged 1 commit into from
Jul 10, 2023

Conversation

Innei
Copy link
Contributor

@Innei Innei commented Jun 22, 2022 •
edited by sxzz
Loading

@Innei Innei changed the title fix: add missing img attr loading fix(runtime-dom): add missing img attr loading Jun 22, 2022
@Innei Innei changed the title fix(runtime-dom): add missing img attr loading types(runtime-dom): add missing img attr loading Jun 23, 2022
@Innei
Copy link
Contributor Author

Innei commented Jun 27, 2022

Hi, @antfu @yyx990803
Since this PR is unresponsive for a long time. I noticed that you are a recent committer for this project. May I ask do you mind applying this changes to the project?

@netlify
Copy link

netlify bot commented Jul 3, 2022

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 694007a
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/62c129a2b745a10008ed44f3

@Innei
Copy link
Contributor Author

Innei commented Jul 7, 2022

Hello, this type of definition has any problems?

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Mar 22, 2023
@sxzz
Copy link
Member

sxzz commented Mar 22, 2023

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented Mar 22, 2023 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
naive-ui ❌ failure
nuxt ❌ failure
pinia ✅ success
router ✅ success
test-utils ✅ success
vant ✅ success
vite-plugin-vue ✅ success
vitepress ✅ success
vue-macros ✅ success
vuetify ✅ success
vueuse ✅ success

@sxzz sxzz requested review from antfu and sodatea March 22, 2023 07:07
@vercel
Copy link

vercel bot commented Apr 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
sfc-playground ✅ Ready (Inspect) Visit Preview Apr 7, 2023 1:43pm

@sxzz sxzz requested a review from yyx990803 April 7, 2023 13:44
@yyx990803 yyx990803 merged commit 68d6b43 into vuejs:main Jul 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

@antfu antfu antfu approved these changes

@BlackCrowxyz BlackCrowxyz BlackCrowxyz approved these changes

@sodatea sodatea Awaiting requested review from sodatea

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImgHTMLAttributes should has a loading propety
6 participants
@Innei @sxzz @vue-bot @antfu @BlackCrowxyz @yyx990803