Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(effectScope): add active property getter #6187

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

webfansplz
Copy link
Member

Close #6186

@LinusBorg
Copy link
Member

The problem with this change is that now we communicate via our types that it's fine to mutate this property in userland - it's part of the types, after all. But that's not* what people should be doing.

So I think a better solution would be to have a dedicated getter for retrieving this information.

@webfansplz webfansplz changed the title chore(effectScope): expose active property as public type feat(effectScope): add active property getter Jun 27, 2022
@webfansplz
Copy link
Member Author

The problem with this change is that now we communicate via our types that it's fine to mutate this property in userland - it's part of the types, after all. But that's not* what people should be doing.

So I think a better solution would be to have a dedicated getter for retrieving this information.

Updated,Thanks for your suggestion.

@yyx990803 yyx990803 merged commit 59ffe5e into vuejs:main Nov 14, 2022
@webfansplz webfansplz deleted the types-effectScope branch November 14, 2022 01:29
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable EffectScope.active in public TypeScript types
4 participants