Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): forward helpers provided by CSS v-bind #6489

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Aug 17, 2022

During SSR build, the _unref helper provided by injecting CSS binding is not forwarded to the main ast. Causing _unref is not defined error on SSR.

fix nuxt/framework#6201
fix nuxt/nuxt#14550

close nuxt/nuxt#14452 as an alternative

Reproduction with Vite: https://stackblitz.com/edit/vitejs-vite-ukhxfu?file=README.md&terminal=run

@antfu antfu added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: sfc-style-vars labels Aug 17, 2022
@antfu antfu requested a review from yyx990803 August 29, 2022 00:10
@yyx990803 yyx990803 merged commit 2024d11 into main Aug 29, 2022
@yyx990803 yyx990803 deleted the fix/css-v-bind-helper-ssr branch August 29, 2022 03:09
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: sfc-style-vars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 _unref is not defined Missing types for vite.vue
2 participants