Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): clean scopeIds when leave node #9863

Closed
wants to merge 2 commits into from
Closed

fix(runtime-core): clean scopeIds when leave node #9863

wants to merge 2 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Dec 18, 2023 •
edited

close #9853

Another solution is to reuse node.scopeIds for better performance. see #9867

huang-julien
huang-julien reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@huang-julien huang-julien left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running it locally, It fixes #9853 :) thank you

@edison1105 edison1105 mentioned this pull request Dec 19, 2023
Merged
yyx990803 pushed a commit that referenced this pull request Dec 19, 2023
@edison1105
fix(compile-sfc): fix identifier prefixing edge case caused by reused…
eb51b23 
… AST (#9867)

close #9853
close #9863
@yyx990803
Copy link
Member

#9867 achieves same fix with better perf

@yyx990803 yyx990803 closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huang-julien huang-julien huang-julien left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edison1105 @yyx990803 @huang-julien