Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspense regression of update and replace a async component at same time in version 3.4.0 #9944

Closed
mmis1000 opened this issue Dec 29, 2023 · 0 comments · Fixed by #9966
Closed

Comments

@mmis1000
Copy link
Contributor

mmis1000 commented Dec 29, 2023

Vue version

3.4.0

Link to minimal reproduction

https://play.vuejs.org/#eNqVU02P2jAQ/SuWLwQpJGzpKQ1oabWHVmq7KnvMJU0G1kv8IdsBVoj/3rFDQgLtaouE4pl5z35jvznSpVLRrgaa0NQUmilLDNhaLTLBuJLaki+SK7LWkpNRFLvAwUdd+UhWtVEgDIREiu+yFhbKkGhYk9OZ1uAzUUhhLClzm5O5AwQjtx6NXa2jBsGYzBfkmAmCPweIdnlVA1I8/ANudUJKGjdyUSgGFriqcgsYEZK2inyEsW8h2cLrPKNuj4ySxH27MG54cY+Yxt2eNKTWoPg120QvRgq8Ky8vowVuzCrQP5Vl2FxGk1Z4RvOqkvtvPmd1DWGbL56h2P4l/2IOLpfRRw0G9A4y2tVsrjdgm/LD6gcccN0VuSzrCtFvFH+BkVXtNDawz7UoUXYP59V+9U/KxObJPBwsXkTblBPqkCePzyi+qLvTf7V+kTuLZp6Hb4a32Lrn1my689PSvIpi4Lkuc9c4D7Hu37hJaakMeqOENRPw6KLg6MqtexKyshpbCl0SjXNmX+zTJi4WOrPTixTvlsnZMv7IqDOO36zvlaHet3o9XiZmMCyf/qPHbdvgsL98nzNLBOwJ4jkzEGg3VijhiXGQtQ10SO6m0+nYU95zHSXbLZbLZRq7xW3bTU8TnqurIWkKQ4dgl40Tn61VJonjohRIK6FiOx0JsLFQPL5HWKzxflDypJT8fhZ9jKZ4vrH9dASGT35rucexwU16rnZ8P0t6okGUoJ3n33fsFa1/9FXp5vjO8ac/el3Vrw==

Steps to reproduce

  1. Open above playground, there is nothing rendered and a crash
  2. Change version to 3.3.13, and now it works

What is expected?

It works like in old version

What is actually happening?

It crashed

System Info

No response

Any additional comments?

It seems change here aa0c13f#diff-069bd39ee093a8545c4e26aa7264c6ba4561a28f07f3d7d7080f4c0f71710281L252-R256 caused branch at

instance.suspenseId === parentSuspense.pendingId
to be triggered, and thus crash at
move(vnode.component!.subTree, container, anchor, moveType)
because it is not resolved yet (As a result, no vnode.component )

It's probably a bug that revealed by an actual fix, because it never fires resolve event before in this situation.

BTW, it also don't work in SSR, but I don't know whether this is a bug of playground or an actual bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants