Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Suspense): skip patch nested suspense if parent suspense is not resolved #10055

Merged
merged 7 commits into from
Jan 11, 2024

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Jan 9, 2024

close #8678

Copy link

github-actions bot commented Jan 9, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.7 kB (+61 B) 34.2 kB (+6 B) 30.8 kB (+17 B)
vue.global.prod.js 147 kB (+61 B) 53.4 kB (+12 B) 47.7 kB (+22 B)

Usages

Name Size Gzip Brotli
createApp 50.1 kB 19.6 kB 17.9 kB
createSSRApp 53.4 kB 20.9 kB 19.1 kB
defineCustomElement 52.4 kB 20.4 kB 18.6 kB
overall 63.8 kB (+61 B) 24.7 kB (+12 B) 22.4 kB (+13 B)

@edison1105 edison1105 changed the title fix(Suspense): avoid patch nested suspense with suspensible true fix(Suspense): avoid patch nested suspense with suspensible true if parent suspense not resolved Jan 9, 2024
@edison1105 edison1105 changed the title fix(Suspense): avoid patch nested suspense with suspensible true if parent suspense not resolved fix(Suspense): avoid patch nested suspense with suspensible true if parent suspense is not resolved Jan 9, 2024
@edison1105 edison1105 marked this pull request as draft January 9, 2024 14:29
@edison1105 edison1105 changed the title fix(Suspense): avoid patch nested suspense with suspensible true if parent suspense is not resolved fix(Suspense): avoid patch nested suspense if parent suspense is not resolved Jan 10, 2024
@edison1105 edison1105 marked this pull request as ready for review January 10, 2024 09:55
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented Jan 10, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
quasar success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@yyx990803
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented Jan 11, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
quasar success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 changed the title fix(Suspense): avoid patch nested suspense if parent suspense is not resolved fix(Suspense): skip patch nested suspense if parent suspense is not resolved Jan 11, 2024
@yyx990803 yyx990803 merged commit bcda96b into vuejs:main Jan 11, 2024
11 checks passed
edison1105 added a commit to edison1105/vuejs-core that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested components in detached branch render while being detached even with child suspensible suspense
3 participants