Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactivity): no longer allows stop computed effect #10290

Closed
wants to merge 19 commits into from
Closed

fix(reactivity): no longer allows stop computed effect #10290

wants to merge 19 commits into from

Conversation

johnsoncodehk
Copy link
Member

fix #10236

johnsoncodehk and others added 18 commits January 23, 2024 09:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.5 kB (+97 B) 34.5 kB (+59 B) 31 kB (+4 B)
vue.global.prod.js 148 kB (+97 B) 53.7 kB (+31 B) 47.9 kB (-15 B)

Usages

Name Size Gzip Brotli
createApp 50.6 kB (+74 B) 19.8 kB (+26 B) 18 kB (+17 B)
createSSRApp 54 kB (+74 B) 21.1 kB (+30 B) 19.2 kB (+39 B)
defineCustomElement 52.9 kB (+74 B) 20.5 kB (+33 B) 18.7 kB (+19 B)
overall 64.3 kB (+74 B) 24.8 kB (+38 B) 22.5 kB (+33 B)

@johnsoncodehk johnsoncodehk changed the title feat(reactivity): no longer allows stop computed effect fix(reactivity): no longer allows stop computed effect Feb 7, 2024
@johnsoncodehk
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented Feb 7, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ❌ failure ❌ failure
nuxt ❌ failure ❌ failure
pinia ✅ success ✅ success
quasar ✅ success ✅ success
radix-vue ❌ failure ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ❌ failure ❌ failure
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ✅ success ✅ success
vuetify ✅ success ✅ success
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

@yyx990803 yyx990803 mentioned this pull request Feb 24, 2024
Merged
yyx990803 added a commit that referenced this pull request Feb 25, 2024
@yyx990803
Refactor reactivity system to use version counting and doubly-linked …
05eb4e0 
…list tracking (#10397)

Bug fixes
close #10236
close #10069

PRs made stale by this one
close #10290
close #10354
close #10189
close #9480
@johnsoncodehk johnsoncodehk mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reactivity maybe be broken with nested computed and vue-router
3 participants
@johnsoncodehk @vue-bot @yyx990803