Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sfc-playground): upgrade @vue/repl #10310

Merged
merged 4 commits into from
Feb 20, 2024
Merged

refactor(sfc-playground): upgrade @vue/repl #10310

merged 4 commits into from
Feb 20, 2024

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Feb 10, 2024

No description provided.

@sxzz sxzz requested a review from yyx990803 February 10, 2024 09:13
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.4 kB 34.4 kB 31 kB
vue.global.prod.js 148 kB 53.7 kB 47.9 kB

Usages

Name Size Gzip Brotli
createApp 50.5 kB 19.7 kB 18 kB
createSSRApp 53.8 kB 21.1 kB 19.3 kB
defineCustomElement 52.8 kB 20.5 kB 18.7 kB
overall 64.2 kB 24.8 kB 22.5 kB


const EditorComponent = shallowRef<typeof Monaco | typeof CodeMirror>()

if (import.meta.env.DEV) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language auto-completion has been implemented

@skirtles-code
Copy link
Contributor

skirtles-code commented Feb 10, 2024

I understand these are likely upstream changes, but...

The preview seems to be showing dark mode, even though I have light mode set:

image

If I toggle dark mode on and off it fixes it, but only until I refresh.

More generally, having dark mode apply to the preview is likely to break the styling in documentation examples that rely on the Playground (throughout the ecosystem, not just in the Vue docs). I don't think this is a good change, it just makes it more work when writing a Playground example.

To give a specific example, this section of the Vue docs contains an example that doesn't work correctly with white text:

The text Hello isn't visible in dark mode, so you can't see it move when dragging the header.

@sxzz
Copy link
Member Author

sxzz commented Feb 11, 2024

Preview sandbox themes now don't follow outside by default.

@yyx990803 yyx990803 merged commit fe5d919 into main Feb 20, 2024
15 checks passed
@yyx990803 yyx990803 deleted the refactor/vue-repl branch February 20, 2024 13:47
wangdaoo pushed a commit to wangdaoo/core that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants