-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sfc-playground): upgrade @vue/repl
#10310
Conversation
Size ReportBundles
Usages
|
|
||
const EditorComponent = shallowRef<typeof Monaco | typeof CodeMirror>() | ||
|
||
if (import.meta.env.DEV) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Language auto-completion has been implemented
I understand these are likely upstream changes, but... The preview seems to be showing dark mode, even though I have light mode set: If I toggle dark mode on and off it fixes it, but only until I refresh. More generally, having dark mode apply to the preview is likely to break the styling in documentation examples that rely on the Playground (throughout the ecosystem, not just in the Vue docs). I don't think this is a good change, it just makes it more work when writing a Playground example. To give a specific example, this section of the Vue docs contains an example that doesn't work correctly with white text: The text |
Preview sandbox themes now don't follow outside by default. |
No description provided.