Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx(reactivity): add getter into computed side effect warning #10386

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

Doctor-wu
Copy link
Contributor

@Doctor-wu Doctor-wu commented Feb 23, 2024

add more info of computed side effect warning
related #10341

@Doctor-wu Doctor-wu changed the title feat(computed): add getter into computed side effect warning feat(reactivity): add getter into computed side effect warning Feb 23, 2024
Copy link

github-actions bot commented Feb 23, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.4 kB (+14 B) 34.4 kB (+3 B) 31 kB (-17 B)
vue.global.prod.js 148 kB (+14 B) 53.7 kB (+2 B) 47.9 kB (-18 B)

Usages

Name Size Gzip Brotli
createApp 50.6 kB (+14 B) 19.7 kB (+4 B) 18 kB (-8 B)
createSSRApp 53.9 kB (+14 B) 21.1 kB (+4 B) 19.2 kB (+19 B)
defineCustomElement 52.8 kB (+14 B) 20.5 kB (+4 B) 18.7 kB (+24 B)
overall 64.3 kB (+14 B) 24.8 kB (+5 B) 22.5 kB (+3 B)

@Doctor-wu Doctor-wu changed the title feat(reactivity): add getter into computed side effect warning dx(reactivity): add getter into computed side effect warning Feb 24, 2024
@yyx990803 yyx990803 merged commit 21e0d6b into vuejs:main Feb 25, 2024
11 checks passed
mgineer85 added a commit to photobooth-app/photobooth-frontend that referenced this pull request Feb 27, 2024
OnlyWick pushed a commit to OnlyWick/core that referenced this pull request Feb 27, 2024
wangdaoo pushed a commit to wangdaoo/core that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants