Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): equal value with a leading 0 do not trigger update #10506

Merged
merged 5 commits into from Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 37 additions & 0 deletions packages/runtime-dom/__tests__/directives/vModel.spec.ts
Expand Up @@ -1269,4 +1269,41 @@ describe('vModel', () => {
expect(foo.selected).toEqual(true)
expect(bar.selected).toEqual(true)
})

// #10503
test('equal value with a leading 0 should trigger update.', async () => {
const setNum = function (this: any, value: any) {
this.num = value
}
const component = defineComponent({
data() {
return { num: 0 }
},
render() {
return [
withVModel(
h('input', {
id: 'input_num1',
type: 'number',
'onUpdate:modelValue': setNum.bind(this),
}),
this.num,
),
]
},
})

render(h(component), root)
const data = root._vnode.component.data

const inputNum1 = root.querySelector('#input_num1')!
expect(inputNum1.value).toBe('0')

inputNum1.value = '01'
triggerEvent('input', inputNum1)
await nextTick()
expect(data.num).toBe(1)

expect(inputNum1.value).toBe('1')
})
})
5 changes: 3 additions & 2 deletions packages/runtime-dom/src/directives/vModel.ts
Expand Up @@ -86,9 +86,10 @@ export const vModelText: ModelDirective<
el[assignKey] = getModelAssigner(vnode)
// avoid clearing unresolved text. #2302
if ((el as any).composing) return

const elValue =
number || el.type === 'number' ? looseToNumber(el.value) : el.value
(number || el.type === 'number') && !/^0\d/.test(el.value)
? looseToNumber(el.value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two small tweaks here:

  1. This leading 0 check should apply to both type="number" and .number modifier cases
  2. The leading 0 check should not apply to decimals like 0.123.

: el.value
const newValue = value == null ? '' : value

if (elValue === newValue) {
Expand Down