fix(runtime-core): fix unwanted warning with disabled compat flag

[jleifeld]

If you disable the "ATTR_FALSE_VALUE" in your compat config you expect that no warning will be thrown afterwards. But this still seems to be the case.

The warning also contains a instruction how to suppress the warning: ...suppress this warning with: configureCompat({ ATTR_FALSE_VALUE: false }). So it will be expected that using this instruction the warning should be suppressed which is not the case.

The issue reproduction can be found in the test. I hope it is the correct place 🙂

My fix switches the order and first checks, if the feature is enabled. If this is the case then it shows the warning. But with a disabled feature the warning for this feature won't be triggered anymore.

[yyx990803]

Thanks for the PR. After looking at this, the logic in softAssertCompatEnabled works as intended - it's just it was incorrectly used in the case for the checks of ATTR_FALSE_VALUE.

I've fixed the root cause in 04729ba and reused the test from this PR.

[jleifeld]

Thanks Evan for fixing the root cause! 👍