fix(compiler-sfc): support keyof for intersection types #11132
Merged
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
reviewed
Jun 14, 2024
| @@ -1688,7 +1688,7 @@ export function inferRuntimeType( | |||
| case 'TSUnionType': | |||
| return flattenTypes(ctx, node.types, scope) | |||
There was a problem hiding this comment.
Should this also apply to UnionTypes?
There was a problem hiding this comment.
Yes, I've also encountered an issue with union types during testing(keyof A):
- When
type A = 'a' | 'b',resolveTypecorrectly returns['String']. - When
type A = number | string,resolveTypereturns['Number', 'String'], but inTypeScript, the type ofAshould be"toString" | "valueOf".
Given this, I believe this might be another issue, and simply adding a parameter might not fix it. Do you think fixing this issue is necessary? If necessary, I'll try to address it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11129