Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): look up prop value from props. #1443

Closed
wants to merge 1 commit into from

Conversation

underfin
Copy link
Member

fix #1236

It fixed in 3.0.0-beta.15 development build. But it doesn't work in 3.0.0-beta.15 production build.

###Bug Description
In dev can be look up successful, because expose props into ctx by exposePropsOnRenderContext.
Other, it will not exist type.props when extend props from mixin.
So, we need look up the prop values from props.

@yyx990803
Copy link
Member

instance.props is not the source of truth since if an absent prop won't be set on it. We still need to use the normalized props options - the reason of the bug was we are only checking it when type.props is present - but when a component has props from mixins but no props declaration on itself it would be skipped.

See e0d19a6

@yyx990803 yyx990803 closed this Jun 26, 2020
@underfin underfin deleted the fix-mixin-prop-get branch June 27, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixin props are not merged into component
2 participants