Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(renderList): warn with v-for has non-integer range number #2247

Merged
merged 9 commits into from Oct 13, 2020
Merged
7 changes: 7 additions & 0 deletions packages/runtime-core/__tests__/helpers/renderList.spec.ts
Expand Up @@ -21,6 +21,13 @@ describe('renderList', () => {
])
})

it('should warn when given a non-integer N', () => {
renderList(3.1, () => {})
expect(
'Please give a non-integer value for v-for range.'
).toHaveBeenWarned()
})

it('should render properties in an object', () => {
expect(
renderList(
Expand Down
5 changes: 5 additions & 0 deletions packages/runtime-core/src/helpers/renderList.ts
@@ -1,5 +1,6 @@
import { VNodeChild } from '../vnode'
import { isArray, isString, isObject } from '@vue/shared'
import { warn } from '../warning'

/**
* v-for string
Expand Down Expand Up @@ -60,6 +61,10 @@ export function renderList(
ret[i] = renderItem(source[i], i)
}
} else if (typeof source === 'number') {
if (__DEV__ && Number.isInteger(source)) {
warn('Please give a non-integer value for v-for range.')
underfin marked this conversation as resolved.
Show resolved Hide resolved
return []
}
ret = new Array(source)
for (let i = 0; i < source; i++) {
ret[i] = renderItem(i + 1, i)
Expand Down
7 changes: 7 additions & 0 deletions packages/server-renderer/__tests__/ssrRenderList.spec.ts
Expand Up @@ -24,6 +24,13 @@ describe('ssr: renderList', () => {
expect(stack).toEqual(['node 0: 1', 'node 1: 2', 'node 2: 3'])
})

it('should warn when given a non-integer N', () => {
ssrRenderList(3.1, () => {})
expect(
'Please give a non-integer value for v-for range.'
).toHaveBeenWarned()
})

it('should render properties in an object', () => {
ssrRenderList({ a: 1, b: 2, c: 3 }, (item, key, index) =>
stack.push(`node ${index}/${key}: ${item}`)
Expand Down
5 changes: 5 additions & 0 deletions packages/server-renderer/src/helpers/ssrRenderList.ts
@@ -1,4 +1,5 @@
import { isArray, isString, isObject } from '@vue/shared'
import { warn } from '@vue/runtime-core'

export function ssrRenderList(
source: unknown,
Expand All @@ -9,6 +10,10 @@ export function ssrRenderList(
renderItem(source[i], i)
}
} else if (typeof source === 'number') {
if (__DEV__ && Number.isInteger(source)) {
warn('Please give a non-integer value for v-for range.')
return
}
for (let i = 0; i < source; i++) {
renderItem(i + 1, i)
}
Expand Down