Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssr): expose SSR render context #2575

Closed
wants to merge 3 commits into from
Closed

Conversation

arpowers
Copy link

@arpowers arpowers commented Nov 8, 2020

Close #2574

@posva posva changed the title feat(ssr): expose SSR render context. Fix #2574 feat(ssr): expose SSR render context Nov 9, 2020
@HcySunYang HcySunYang added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: ssr labels Mar 31, 2021
@skirtles-code
Copy link
Contributor

I know this PR is very old, but...

Isn't the functionality being added here already available with renderToString? If I've understood correctly, this PR is proposing adding something like this:

const { result, context } = await renderToContext(app)

But I think this can already be achieved using:

const context = {}
const result = await renderToString(app, context)

The output of any teleports will then be accessible via context.teleports.

Docs: https://vuejs.org/api/ssr.html#ssr-context

Perhaps I'm missing something, but I suspect this PR can be closed.

@arpowers
Copy link
Author

arpowers commented Apr 9, 2024

Agree. Haven't had an issue with it lately. It must have been resolved.

@edison1105 edison1105 closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: ssr
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

[SSR] Render Teleports Distinctly e.g. renderToContext()
4 participants