Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): instanceWatch should pass this.proxy to source as the first argument #2753

Merged
merged 6 commits into from Feb 9, 2021
Merged

fix(runtime-core): instanceWatch should pass this.proxy to source as the first argument #2753

merged 6 commits into from Feb 9, 2021

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Dec 7, 2020 •
edited

close #2731

@edison1105 edison1105 closed this Dec 7, 2020
@edison1105 edison1105 reopened this Dec 7, 2020
@edison1105 edison1105 changed the title fix(runtime-core): this is no longer passed as the first argument of this.$watch fix(runtime-core): instanceWatch call with this.proxy Dec 7, 2020
posva
posva requested changes Dec 7, 2020
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests?

@edison1105 edison1105 changed the title fix(runtime-core): instanceWatch call with this.proxy fix(runtime-core): instanceWatch should pass this.proxy to source Dec 7, 2020
@edison1105 edison1105 changed the title fix(runtime-core): instanceWatch should pass this.proxy to source fix(runtime-core): instanceWatch should pass this.proxy to source as the first argument Dec 7, 2020
@edison1105
Copy link
Member Author

Can you add tests?

Done!

@edison1105 edison1105 requested a review from posva December 7, 2020 14:31
@LongTengDao
Copy link
Contributor

@posva Hi~ I saw this PR was not released in 3.0.5. Is here any problem left? Will this be merged in 3.0.6? Thanks~

@posva posva added 🐞 bug Something isn't working 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Feb 7, 2021
@LinusBorg LinusBorg added this to Planned, might need fresh review in Next Patch Feb 9, 2021
@LinusBorg LinusBorg moved this from Planned, might need fresh review to Approved in Next Patch Feb 9, 2021
@LinusBorg LinusBorg merged commit ec8fd10 into vuejs:master Feb 9, 2021
Next Patch automation moved this from Approved to Done Feb 9, 2021
@yyx990803 yyx990803 moved this from Done to Final (Reviewed by Evan) in Next Patch Feb 23, 2021
This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
@yangmingshan
Copy link
Contributor

yangmingshan commented Apr 14, 2021 •
edited

So this PR pass this.proxy to this.$watch() and composition API watch(), but we shouldn't leak this.proxy to setup() right?

@yangmingshan yangmingshan mentioned this pull request Apr 14, 2021
Closed
@edison1105
Copy link
Member Author

So this PR pass this.proxy to this.$watch() and composition API watch(), but we shouldn't leak this.proxy to setup() right?

oh, my fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

this is no longer passed for the first argument of this.$watch
5 participants
@edison1105 @LongTengDao @yangmingshan @posva @LinusBorg