Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: add eslint ruler, 'require-await' #4427

Closed
wants to merge 2 commits into from

Conversation

zhangenming
Copy link
Contributor

inspire by #4421
Whether this is necessary?

@zhangenming
Copy link
Contributor Author

Another problem, thanks

now the Package lint field :
"lint": "eslint --ext .ts packages/*/src/**.ts",
Why only src, should tests be included?:
"lint": "eslint --ext .ts packages/*/{src,__tests__}/**.ts",

@posva posva added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Aug 24, 2021
@yyx990803
Copy link
Member

This affects a number of async setup() test cases where they are intentionally async without using await.

@zhangenming
Copy link
Contributor Author

This affects a number of async setup() test cases where they are intentionally async without using await.

maybe...so what to do next...
just close this pr? or Do some modifications...

@yyx990803
Copy link
Member

Closing as stale

@yyx990803 yyx990803 closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants