New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(reactivity) : fixed a small copy & paste mistake in ref.spec.ts #4867

Merged

yyx990803 merged 1 commit into vuejs:master from mehanalavimajd:test/reactivity

Nov 26, 2021

Contributor

mehanalavimajd commented Oct 27, 2021

Hi , I saw this code in the ref.spec.ts:

https://github.com/vuejs/vue-next/blob/5eb72630a53a8dd82c2b8a9705c21a8075161a3d/packages/reactivity/__tests__/ref.spec.ts#L32-L38
you can see that a.value = 2 has repeated twice and I guess the second part is for checking that the calls won't change after setting a.value to same number but expect(dummy).toBe(2) has repeated again and that's useless because it has a test at line 34


          fixed a copy & paste mistake in ref.spec.ts

Contributor

caozhong1996 commented Oct 28, 2021

It does make sense if I'm not an obsessive😂

yyx990803 merged commit 2a4f134 into vuejs:master

mehanalavimajd deleted the test/reactivity branch

November 26, 2021 12:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment