Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reactivity): fix typo in types #4889

Merged
merged 1 commit into from Nov 2, 2021
Merged

chore(reactivity): fix typo in types #4889

merged 1 commit into from Nov 2, 2021

Conversation

m4rvr
Copy link
Contributor

@m4rvr m4rvr commented Nov 2, 2021

No description provided.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit d56f115 into vuejs:master Nov 2, 2021
@WORMSS
Copy link

WORMSS commented Nov 4, 2021

I am glad you spotted this, I was just about to do the PR myself. Saved me the trouble.

@m4rvr
Copy link
Contributor Author

m4rvr commented Nov 4, 2021

I am glad you spotted this, I was just about to do the PR myself. Saved me the trouble.

Yeah my code was wrong and the TS error showed me the typo. I was a bit surprised but here we go. 馃槃

@WORMSS
Copy link

WORMSS commented Nov 4, 2021

Nice. I had only just started doing Vue3 for about 20 minutes.. but I am super nosey of "why/how/what" things are doing and just started digging into the .d.ts files as a good place to start. Spotted that.
Hope I can help more in the future once I got a bit of time under my belt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants