Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): imports in <script> should not be exposed #4970

Closed
wants to merge 1 commit into from
Closed

fix(compiler-sfc): imports in <script> should not be exposed #4970

wants to merge 1 commit into from

Conversation

HcySunYang
Copy link
Member

Fix: #3238

@HcySunYang HcySunYang added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Nov 19, 2021
@egoist
Copy link

egoist commented Nov 19, 2021

@knightly-bot build this

@yyx990803
Copy link
Member

yyx990803 commented Nov 25, 2021 •
edited

So I misread the initial discussion on wechat because i was on a phone and didn't see the whole test case - in this case it is actually intended - imports and const declarations in normal <script> should be exposed to the template if (and only if) <script setup> is also used.

@yyx990803 yyx990803 closed this Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imports in normal <script> are exposed to template when using alongside <script setup>
3 participants
@HcySunYang @egoist @yyx990803