fix(ssr): render teleport inside async component #5187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjedlicka
changed the title
|
Closes #4440 |
adamjedlicka
changed the title
|
i am dealing with the exakt same problem. Is there anything new on when this PR will be merged? |
LinusBorg
added
scope: teleport
scope: ssr
🔨 p3-minor-bug
yyx990803
moved this from Planned, might need fresh review
to Open for Review
in Next Patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teleports inside async components weren't SSR rendered into the
ctx.teleportsbut were in thectx.__teleportBuffers. This PR fixes the issue.