feat: improve treeshakeability #5682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs-coverage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-sfc-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
fnlctrl
commented
Apr 7, 2022
| target.$.accessCache[key] = 0; | ||
| } else if (hasOwn(descriptor,'value')) { | ||
| target.$.accessCache[key] = 0 | ||
| } else if (hasOwn(descriptor, 'value')) { |
There was a problem hiding this comment.
These lines are changed by prettier, not sure why they weren't formatted when initially merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More
/*#__PURE__*/markers are added to improve treeshakeability. Intended for libaries that bundle vue.Background
I was writing a library that exports some pure function and some UI-related function to render something. To make it standalone, vue is bundled. To simplify build setup and .d.ts generation, the whole library is bundled into one ESM file.
I created a test app with vite and found even when UI-related functions aren't imported (they depend on vue), the resulting app bundle contains some vue code that wasn't removed. This PR contains all that I could find that lacked
/*#__PURE__*/marking, and by adding these all unused code were correctly removed.