Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): prevent runtime errors when using suspense #6095

Closed
wants to merge 1 commit into from
Closed

fix(runtime-core): prevent runtime errors when using suspense #6095

wants to merge 1 commit into from

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Jun 10, 2022 •
edited

From vuetifyjs/vuetify#15215 (remove the patch)

Screenshot_20220608_013935
Screenshot_20220608_014012

I didn't manage to reproduce it anywhere else though: playground attempt

No idea if this patch is correct, but the tests pass and I haven't seen any other errors yet.

@KaelWD KaelWD mentioned this pull request Jul 5, 2022
Merged
8 tasks
@ml1nk
Copy link

ml1nk commented Nov 10, 2022

We are using vuetify 3.0.1 and vue 3.2.44 together with some async components and suspense. We are also seeing the second picture (readind 'parentNode') randomly on navigation.

Is there progress on resolving this or is there some way to help?

@ml1nk ml1nk mentioned this pull request Nov 13, 2022
Closed
@Akryum
Copy link
Member

Akryum commented Feb 1, 2023

Seeing the 3rd one randomly too

@KaelWD KaelWD mentioned this pull request Apr 9, 2023
Merged
3 tasks
@KaelWD KaelWD mentioned this pull request May 3, 2023
Closed
@mostafaznv
Copy link

any news?

@devonik
Copy link

devonik commented Sep 25, 2023

Anything new here ?

@edison1105 edison1105 mentioned this pull request Nov 3, 2023
Closed
@edison1105 edison1105 mentioned this pull request Nov 29, 2023
Closed
@robin-dongbin
Copy link

Anything new ?

@KaelWD
Copy link
Contributor Author

KaelWD commented Dec 12, 2023

#7290 also fixes this and probably in a better way.

yyx990803 pushed a commit that referenced this pull request Dec 12, 2023
@mmis1000
fix(runtime-core): fix suspense crash when patching non-resolved asyn…
bb0c889 
…c setup component (#7290)

close #5993
close #6463
close #6949
close #6095
close #8121
@KaelWD KaelWD closed this Dec 13, 2023
@devonik
Copy link

devonik commented Dec 13, 2023

🤩 looking forward when the other merged PR will be released

@KaelWD
Copy link
Contributor Author

KaelWD commented Apr 10, 2024

@ml1nk @Akryum Are you still getting this with vue 3.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: suspense
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@KaelWD @ml1nk @Akryum @mostafaznv @devonik @robin-dongbin @yyx990803