Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): v-model can update correctly when the element is an input of type number #7004

Merged
merged 42 commits into from
Nov 9, 2023

Conversation

baiwusanyu-c
Copy link
Member

@baiwusanyu-c baiwusanyu-c commented Nov 1, 2022

close: #7003

@baiwusanyu-c baiwusanyu-c changed the title v-model can update correctly when the element is an input of type number fix(runtime-dom): v-model can update correctly when the element is an input of type number Nov 1, 2022
@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit d566a1a
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6369ea81fc93b8000df23ea0

@sxzz sxzz added the 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. label Nov 16, 2022
@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
sfc-playground ⬜️ Ignored (Inspect) Apr 6, 2023 0:44am

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.4 kB (-13 B) 32.9 kB (-3 B) 29.7 kB (+28 B)
vue.global.prod.js 132 kB (-13 B) 49.6 kB (-2 B) 44.5 kB (-28 B)

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.3 kB
createSSRApp 51.1 kB 20.1 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@pikax pikax added the ready to merge The PR is ready to be merged. label Oct 20, 2023
@yyx990803 yyx990803 merged commit 40f4b77 into vuejs:main Nov 9, 2023
11 checks passed
@baiwusanyu-c baiwusanyu-c deleted the bwsy/fix/vModel branch November 9, 2023 07:45
@sadeghbarati
Copy link

sadeghbarati commented Nov 9, 2023

Wow, look at those merges.. really appreciated that you kept it in sync with the main branch throughout the year

If Vue had auto-publish (npm install vue-prs@fix-vmodel) on PR branches that would be so helpful, not just for the maintainer but also for Vue users

Here is a proposal for PRs

  • Explain PR and related issues
  • What is excepted and what's not
  • How to monkey test it

In this way, everyone could help and review/test the PRs

@sodatea sry for mention WDYT? I know it's hard but at least I said my opinion xd

I may be a mid-level developer, but at least I can help with testing
But if you explain once how to test and debug properly (just like contribution guides)


Kina real example of what am I talking about

Svelte 5 runes Discord

@yyx990803
Copy link
Member

The PRs being merged recently are largely bug fixes.
Feature PRs that get merged directly are also usually ones that are self-explanatory.

Big features / changes like Svelte runes will have dedicated RFCs at https://github.com/vuejs/rfcs.

@vuejs vuejs locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: v-model
Projects
Development

Successfully merging this pull request may close these issues.

v-model overrides the value of a number with trailing zeros
5 participants