fix(runtime-core): ensure jobs are in the correct order #7748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2023
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Closed
|
LGTM |
edison1105
added
the
❗ p4-important
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
yyx990803
force-pushed
the
pre-watcher-sorting
branch
from
84d2169
to
c7e63ef
Compare
|
@edison1105 ecosystem-ci failures are due to the branch being very outdated. I just force rebased. |
Size ReportBundles
Usages
|
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
I've looked into #7576 in-depth before and this PR is correct |
yyx990803
pushed a commit
that referenced
this pull request
Oct 21, 2023
lumozx
pushed a commit
to lumozx/core
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7576.
There is an existing PR to fix this issue, #7622, but I believe it introduces some new problems. The changes to
findInsertionIndex()that I'm proposing here are quite different to the changes in that PR, so I decided it was better to open a new PR rather than just adding review feedback to the existing PR.The additions to the first test case are exactly the same as in #7622, confirming that this fix also fixes the original problem. I've then added an extra test case, checking some of the edge cases that #7622 misses.
Whether the new job is
pre: truedoesn't affect the insertion point. Either way, the job should be inserted after anyprejobs with the same id. If there is a job with the same id withoutpre: true(there can only be one in the active part of the queue) then the insertion point should be before that job.