Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): defining a custom element from the defined Component with emits #7937

Merged
merged 5 commits into from
Nov 10, 2023
Merged

fix(types): defining a custom element from the defined Component with emits #7937

merged 5 commits into from
Nov 10, 2023

Conversation

rudyxu1102
Copy link
Contributor

Fixes #7782

Related to #7782 (comment)

@pikax pikax assigned pikax and unassigned pikax Oct 20, 2023
@Ibbus93 Ibbus93 mentioned this pull request Oct 27, 2023
Closed
@pikax pikax added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. labels Nov 3, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.4 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@yyx990803 yyx990803 merged commit 5d932a8 into vuejs:main Nov 10, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: types
Projects
Issue / PR Management
Status: Merged
Next Minor
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

defineCustomElement type error when component defines emit and imports other component
3 participants
@rudyxu1102 @pikax @yyx990803