fix(reactivity): Pass oldValue to triggerRefValue to satisfy interface DebuggerEventExtraInfo #8210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I just tried applying these changes locally to the latest main.
The conflicts proved much simpler to resolve than I was expecting and it appears these changes still work.
I was worried about the impact on production bundle size, so I checked that too. It seems to add 2 bytes, for the extra parameter on triggerRefValue. Everything else is removed.
edison1105
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: vuejs/pinia#2061
The
DebuggerEventExtraInfotriggered by a computed ref doesn't have the fieldoldValue.For consistency (consistent with
reactive), addedoldValueto debuggerEventExtraInfo.