fix(compiler-sfc): don't match property access in dev mode import usage check #8897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
requested changes
Aug 2, 2023
sxzz
approved these changes
Aug 3, 2023
| @@ -20,7 +20,7 @@ export function isImportUsed(local: string, sfc: SFCDescriptor): boolean { | |||
| return new RegExp( | |||
| // #4274 escape $ since it's a special char in regex | |||
| // (and is the only regex special char that is valid in identifiers) | |||
| `[^\\w$_]${local.replace(/\$/g, '\\$')}[^\\w$_]` | |||
| `[^\\w$.]${local.replace(/\$/g, '\\$')}[^\\w$]` | |||
There was a problem hiding this comment.
Don't we also need to account for . being used as part of a spread operator? e.g.:
I also wonder whether we should account whitespace after . operators. e.g. Foo . Bar . Baz?
yyx990803
added a commit
that referenced
this pull request
Dec 1, 2023
|
I decided to rethink how import usage check should work and implemented AST-based checks in #9729 Still, thanks for the PR! |
sxzz
referenced
this pull request
in vuejs/core-vapor
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nuxt/nuxt#22416