fix(timeline): Reset layer status when selected layer is hidden in ti…

…meline (#2109)
vuejs · Feb 4, 2024 · 8b6f96b · 8b6f96b
1 parent 990367e
commit 8b6f96b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/packages/app-frontend/src/features/timeline/TimelineEventList.vue b/packages/app-frontend/src/features/timeline/TimelineEventList.vue
@@ -144,9 +144,8 @@ export default defineComponent({
     // Auto bottom scroll
 
     function scrollToBottom () {
-      if (!scroller.value) return
-
       requestAnimationFrame(() => {
+        if (!scroller.value) return
         const scrollerEl = scroller.value.$el
         scrollerEl.scrollTop = scrollerEl.scrollHeight
       })

diff --git a/packages/app-frontend/src/features/timeline/composable/layers.ts b/packages/app-frontend/src/features/timeline/composable/layers.ts
@@ -66,9 +66,22 @@ export function useLayers () {
     return list.includes(layer.id)
   }
 
+  function resetSelectedStatus () {
+    selectedLayer.value = null
+    inspectedEvent.value = null
+    selectedEvent.value = null
+    hoverLayerId.value = null
+    setStorage('selected-layer-id', '')
+  }
+
   function setLayerHidden (layer: Layer, hidden: boolean) {
     const list = getHiddenLayers(currentAppId.value)
     const index = list.indexOf(layer.id)
+
+    if (selectedLayer.value === layer) {
+      resetSelectedStatus()
+    }
+
     if (hidden && index === -1) {
       list.push(layer.id)
     } else if (!hidden && index !== -1) {