Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: pluginOn[k].callHandlers is not a function #1422

Closed
anish2690 opened this issue Apr 26, 2021 · 7 comments
Closed

TypeError: pluginOn[k].callHandlers is not a function #1422

anish2690 opened this issue Apr 26, 2021 · 7 comments

Comments

@anish2690
Copy link

Version

6.0.0-beta.8

Browser and OS info

Firefox & OSX

Steps to reproduce

Tried to enable it on a older Vue 2 project but not able to detect app, but works fine for newly created boilerplate from Vue CLI

What is expected?

Should detect Vue 2 app

What is actually happening?

Not able to find Vue 2 app

image

@liuxilu
Copy link

liuxilu commented Apr 26, 2021

Me too, but on 3.0.5 with direct <script> usage.

@jbmaisner
Copy link

jbmaisner commented Apr 27, 2021

Same here, on Vue 3.0.11, Chrome, OSX.
Unfortunately didn't find the origin :/
It happened right after Devtool update

@cgarnier
Copy link

cgarnier commented Apr 29, 2021

I got the same issue.
I my project, i got a lib that add some methods to arrays.
The in is taking array keys AND the methods names. It should be replaced by await Array.map or something.

for (k in []) console.log(k)
 _map
 _reduce
 _filter
 _find
 _findIndex
 _sort
 _reverse

I know it s a bad idea to extend arrays prototype like that but there is weird stuff in any projects :D

@cgarnier
Copy link

cgarnier commented Apr 29, 2021

To reproduce, just add

Array.prototype.foo = 'bar'

In a vue(2 || 3) project.

cgarnier added a commit to cgarnier/vue-devtools that referenced this issue Apr 29, 2021
vuejs#1422
Usage of `in` iterate on custom prototype methods. `of` should fix it.
@liuxilu
Copy link

liuxilu commented Apr 30, 2021

I defined enumerable prototype methods as well.
I solved this by creating nonenumerable methods with Object.defineProperty.
for...of seems won't fix this as it still enumerate enumerables.
Edit: for...of is not proto-chaining, so it will work.

@Akryum
Copy link
Member

Akryum commented May 5, 2021

😓

Akryum added a commit that referenced this issue May 5, 2021
@cgarnier
Copy link

cgarnier commented May 5, 2021

Ty @Akryum

@Akryum Akryum closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants