Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnamed component's tag name shows as its file path #256

Closed
UncleBill opened this issue Feb 16, 2017 · 7 comments
Closed

unnamed component's tag name shows as its file path #256

UncleBill opened this issue Feb 16, 2017 · 7 comments
Assignees
Labels

Comments

@UncleBill
Copy link
Contributor

env

  • chrome 56.0.2924.87
  • vue 2.1.10
  • vue-devtools 3.0.8

screenshot

image

Naming <ProgressBar>

{
name: 'progress-bar'
}

image

fix this tag.

@posva
Copy link
Member

posva commented Feb 16, 2017

I couldn't reproduce using webpack. Can you please provide a minima repro for this? Thanks!

@UncleBill
Copy link
Contributor Author

Can you please provide a minima repro for this?

I can't now. It was OK yesterday. And it just happened with none config changed.
I will try reverting my code base.
PS: I use the official boilerplate vuejs-templates/webpack (webpack@v1)

@posva
Copy link
Member

posva commented Feb 16, 2017

tested both v2 and v1 template on OSX and works nicely.
It don't have to be right now 😄 Doing it in the following days is just fine

@UncleBill
Copy link
Contributor Author

OK! Thanks for reply!

@posva posva added bug and removed need repro labels Feb 18, 2017
@posva
Copy link
Member

posva commented Feb 18, 2017

I just run npm run dev in the devtools, in windows, and it happens

@posva posva self-assigned this Feb 18, 2017
@posva
Copy link
Member

posva commented Feb 18, 2017

@yyx990803 So the basename fn from the path package (which is different from the node one) is not doing its job. Do you know where is that package so I can open an issue there? I searched in the webpack repo with no luck.
We can also use a replace on the file file.replace(/^[a-zA-Z]:/, '').replace(/\\/g, '/') to temporaly fix this or use a path browser package like https://github.com/snowyu/path.js

@yyx990803
Copy link
Member

@posva hmm, looks like Webpack's path shim is not OS-agnostic. We can just use a better basename fn instead.

posva added a commit that referenced this issue Feb 19, 2017
posva added a commit that referenced this issue Feb 19, 2017
posva added a commit that referenced this issue Feb 19, 2017
posva added a commit that referenced this issue Feb 19, 2017
posva added a commit that referenced this issue Feb 20, 2017
yyx990803 pushed a commit that referenced this issue Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants