Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An idea of making vue-devtools work with iframes #396

Closed
crimx opened this issue Aug 21, 2017 · 7 comments
Closed

An idea of making vue-devtools work with iframes #396

crimx opened this issue Aug 21, 2017 · 7 comments

Comments

@crimx
Copy link

crimx commented Aug 21, 2017

As far as I understand, vue-devtools hooks __VUE_DEVTOOLS_GLOBAL_HOOK__ in a page's window, then manipulates it through src/backend.

I don't see why not make it work with iframes throungh all_frames option on chrome. The hooks work the same, except the front end part might change to lazy connection with the hook that is selected by user.

@posva
Copy link
Member

posva commented Aug 21, 2017

Hmm, the all_frames doc isn't very clear to me. Wouldn't this run a copy of the extension in every iframe?

@crimx
Copy link
Author

crimx commented Aug 21, 2017

@posva not a copy of the extension, just a copy of the specified content script, the hook script in this case.

@posva
Copy link
Member

posva commented Aug 21, 2017

ok, I'll have to take a look at that option

@davinov
Copy link

davinov commented Aug 23, 2017

This would be quite useful, especially with the recent release of vue storybooks (which uses iframes).
@posva I'd be happy to help if needed!

@posva
Copy link
Member

posva commented Aug 23, 2017

I started some work on the iframes branch but it experimental and doesn't work correctly yet. Feel free to give it a look and improve it 😄

@wmichelin
Copy link

This would be super helpful!

@Akryum
Copy link
Member

Akryum commented Jan 4, 2018

Let's close this in favor of #353.

@Akryum Akryum closed this as completed Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants