List getters in Vuex tab #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonySendra
commented
Feb 15, 2017
| @@ -158,7 +168,7 @@ module.exports = { | |||
| .frame('target') | |||
| .click('.increment') | |||
| .frame(null) | |||
| .assert.count('.history .entry', 1) | |||
| .assert.count('.history .entry', 4) | |||
There was a problem hiding this comment.
Because 3 more mutations added
|
@AnthonySendra thanks for this PR - looking great at the moment, I just need to pull it locally to try it out. Will probably have to do that after shipping Vue core 2.2 though. |
|
#262 can be closed if this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR allows to list all getters defined in the application, just next to the state.
I have a huge application with complex getters, because my state needs to be manipulate (flatten, transformed, ...). Sometimes, it's very difficult to guess the result of the getter according to the state.
In the dev exemple I added a simple getter
isPositivethat returnstrueifcountis upper or equal than zero.Implementation:
vuex/importStatedoesn't exist anymore. When the user import a state, I send an event through the bridge in order to get updated getters. The bridge will send back thevuex:initevent to initialize the state and getters (here).baseandinitialhave nowstateandgettersas attributes