-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync 'classifyComponents' settings with backend #533
Conversation
src/backend/highlighter.js
Outdated
@@ -30,7 +31,8 @@ export function highlight (instance) { | |||
const rect = getInstanceRect(instance) | |||
if (rect) { | |||
let content = '' | |||
const name = getInstanceName(instance) | |||
let name = getInstanceName(instance) | |||
claissifyComponents && (name = classify(name)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are there so many condition && statement
instead of if (condition) statement
😆 I think we should stop adding more of those
src/backend/index.js
Outdated
@@ -39,6 +40,8 @@ export function initBackend (_bridge) { | |||
} else { | |||
hook.once('init', connect) | |||
} | |||
|
|||
bridge && config(bridge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when do you finnd yourself with no bridge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested
Apply 'Format component names' user settings to component highlighter