New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web Components: Add Event Handling Caveat #1890
Conversation
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@LinusBorg I see you were assigned to review. Any thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Sorry for the delay getting back to you.
Co-authored-by: skirtle <65301168+skirtles-code@users.noreply.github.com>
LGTM |
Hold it for now - I believe this should be considered a bug and is fixable. |
@yyx990803 For camelCase it mighr be, i think i even have an open PR for that? Not sure 😅 But in Vue core we map |
…mes on custom elements close vuejs/docs#1708 close vuejs/docs#1890
Description of Problem
The custom elements section currently includes an incorrect score from Custom Elements Everywhere. Even if Custom Elements Everywhere decided to accept custom directives as satisfactory (which they have not), I don't think the score is all that relevant. Bottom line: custom elements work, and there are some caveats.
The caveat around listening for events with capital letters currently is not documented, and neither is the recommended solution.
Proposed Solution
Additional Information
Related issue: vuejs/core#5401
Related closed PR: #1553
Related RFC discussion: vuejs/rfcs#451
Closes #1708