Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move component v-model to its own page #2153

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

skirtles-code
Copy link
Contributor

Motivation

The docs for component v-model are currently located at the end of the page about component events. I think that made sense historically, but there's now enough material on both topics to justify splitting them into two pages.

While it's clearly necessary to document component events before component v-model, I don't think they're really the same topic. I frequently find myself linking to the docs for component v-model, and it took me a while to 'learn' that they lived at the bottom of the page about events. Time and again I would look for a separate page, like the page about 'Form Input Bindings' for using v-model on native elements.

Redirects

I've updated internal links, but I've also tried to provide redirects for external links to the v-model docs. See the code at the top of events.md for details.

Notes for translators

I've tried to make minimal changes to the text itself. The new v-model.md should contain almost the same content that was in events.md. The only intentional changes I've made to the text are:

  • Updating the headings. In particular, headings are now ## instead of ###.
  • The top of the page, up to the first example. The previous wording assumed it was part of the page about events, so I've written a brief new introduction.

@netlify
Copy link

netlify bot commented Jan 7, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 333c1d9
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/63b8f9ef4504540008621366
😎 Deploy Preview https://deploy-preview-2153--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@yyx990803 yyx990803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skirtles-code great work on moving v-model to a separate doc!

@NataliaTepluhina NataliaTepluhina merged commit e39b5d1 into vuejs:main Jan 8, 2023
Abdelaziz18003 referenced this pull request in vuejs-translations/docs-ar Jan 11, 2023
Abdelaziz18003 referenced this pull request in vuejs-translations/docs-ar Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants