💬 Fix syntax error in defineEmits example #2809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
phillt
changed the title
|
semi colon is not required there. It’s valid syntax. |
|
compiler throws errors, are you sure? Perhaps the error is within the bundler and not the docs.
…On Thu, Apr 18, 2024 at 12:53 PM Divyansh Singh ***@***.***> wrote:
semi colon is not required there. It’s valid syntax.
—
Reply to this email directly, view it on GitHub
<#2809 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATXSOMH3S4DGMPWZ2BDIZDY6AQCFAVCNFSM6AAAAABGN5J2MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRVGE2DANBVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
You might not have specified |
|
|
|
|
|
In all fairness, there could be something wrong with my setup. |
|
If it's on my end, it's not that big of a deal. But I just wanted to make sure the docs were good. Thanks for taking the time to review. |
|
You need newline there or comma or semi colon. The docs have newline. They are correct. |
|
🤦🏻 the error is in me. What a twist. I didn't RTFM well. Thank you.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Current documentation of Type-only props/emit declarations has a syntax error in the type parameters of
defineEmits. It is missing a semi colon.Proposed Solution
Add missing semi colon:
Additional Information
N/A