Omit BinaryExpression in v-model references check (#243)

vuejs · Nov 24, 2017 · ac581a4 · ac581a4
1 parent 2793ca2
commit ac581a4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/rules/valid-v-model.js b/lib/rules/valid-v-model.js
@@ -139,7 +139,7 @@ function create (context) {
 
         for (const reference of node.value.references) {
           const id = reference.id
-          if (id.parent.type === 'MemberExpression') {
+          if (id.parent.type === 'MemberExpression' || id.parent.type === 'BinaryExpression') {
             continue
           }
 

diff --git a/tests/lib/rules/valid-v-model.js b/tests/lib/rules/valid-v-model.js
@@ -67,6 +67,14 @@ tester.run('valid-v-model', rule, {
       filename: 'test.vue',
       code: '<template><div><div v-for="x in list"><input v-model="x.foo"></div></div></template>'
     },
+    {
+      filename: 'test.vue',
+      code: '<template><div><div v-for="x in list"><input v-model="foo[x]"></div></div></template>'
+    },
+    {
+      filename: 'test.vue',
+      code: '<template><div><div v-for="x in list"><input v-model="foo[x - 1]"></div></div></template>'
+    },
     {
       filename: 'test.vue',
       code: '<template><input :type="a" v-model="b"></template>'