fix some unit tests

vuejs · Oct 3, 2022 · bfa7a9f · bfa7a9f
1 parent 681608f
commit bfa7a9f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 12 deletions.
diff --git a/lib/rules/force-types-on-object-props.js b/lib/rules/force-types-on-object-props.js
@@ -86,7 +86,7 @@ module.exports = {
           )
         for (const prop of properties) {
           if (!prop) {
-            break
+            continue
           }
           if (isLooksLike(prop.value, { type: 'Identifier', name: 'Object' })) {
             context.report({

diff --git a/tests/lib/rules/force-types-on-object-props.js b/tests/lib/rules/force-types-on-object-props.js
@@ -8,16 +8,25 @@ const RuleTester = require('eslint').RuleTester
 const rule = require('../../../lib/rules/force-types-on-object-props')
 
 const template = (prop) => `
-<template></template>
-<script>
+<script lang="ts">
+import { Prop } from 'vue/types/options';
 export default {
+	props: {
+		prop: {
+			${prop}
+		}
+	}
 }
 </script>  
 `
 
 const ruleTester = new RuleTester({
   parser: require.resolve('vue-eslint-parser'),
-  parserOptions: { ecmaVersion: 2015,   sourceType: 'module' }
+  parserOptions: {
+    ecmaVersion: 2015,
+    sourceType: 'module',
+    parser: '@typescript-eslint/parser'
+  }
 })
 
 ruleTester.run('force-types-on-object-props', rule, {
@@ -54,35 +63,31 @@ ruleTester.run('force-types-on-object-props', rule, {
       code: template('type: Object as any'),
       errors: [
         {
-          message:
-            'Object props should be typed like this: "type: Object as Prop<T>"'
+          message: 'Object props has to contains type.'
         }
       ]
     },
     {
       code: template('type: Object as {}'),
       errors: [
         {
-          message:
-            'Object props should be typed like this: "type: Object as Prop<T>"'
+          message: 'Object props has to contains type.'
         }
       ]
     },
     {
       code: template('type: Object as unknown'),
       errors: [
         {
-          message:
-            'Object props should be typed like this: "type: Object as Prop<T>"'
+          message: 'Object props has to contains type.'
         }
       ]
     },
     {
       code: template('type: Object as string'),
       errors: [
         {
-          message:
-            'Object props should be typed like this: "type: Object as Prop<T>"'
+          message: 'Object props has to contains type.'
         }
       ]
     }