Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue/component-tags-order should enforce order between <script> and <script setup> #1819

Closed
achaphiv opened this issue Mar 17, 2022 · 0 comments · Fixed by #1825
Closed

vue/component-tags-order should enforce order between <script> and <script setup> #1819

achaphiv opened this issue Mar 17, 2022 · 0 comments · Fixed by #1825

Comments

@achaphiv
Copy link

achaphiv commented Mar 17, 2022

What rule do you want to change?
vue/component-tags-order

Does this change cause the rule to produce more or fewer warnings?
More.

How will the change be implemented? (New option, new default behavior, etc.)?
New configuration option.

Possibly the new default?

Example

<script setup>
  // ...
</script>

<script>
  // ...
</script>

What does the rule currently do for this code?
Nothing.

What will the rule do after it's changed?

Move <script setup> below <script>.

<script>
  // ...
</script>

<script setup>
  // ...
</script>
doug-wade added a commit to doug-wade/eslint-plugin-vue that referenced this issue Mar 24, 2022
doug-wade added a commit to doug-wade/eslint-plugin-vue that referenced this issue Mar 24, 2022
ota-meshi added a commit that referenced this issue Apr 11, 2022
* Fix #1819: Enforce order between script and script setup

* update defaults to match documentation

* Use CSS selector syntax

* remove incorrect documentation of default behavior for script setup

* Fix bug with multiple not pseudo-selectors

* revert component tags order docs

* update docs

* Update error message

* update headers

* update docs more better

* Update tests/lib/rules/component-tags-order.js

Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>

* Update tests/lib/rules/component-tags-order.js

Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>

* Update tests/lib/rules/component-tags-order.js

Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>

* Update tests/lib/rules/component-tags-order.js

Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>

* Update docs/rules/component-tags-order.md

Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>

* don't move the message block

Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant