Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin-html v2 compatibility #2

Closed
BenoitZugmeyer opened this issue Jan 17, 2017 · 0 comments
Closed

eslint-plugin-html v2 compatibility #2

BenoitZugmeyer opened this issue Jan 17, 2017 · 0 comments
Labels

Comments

@BenoitZugmeyer
Copy link

I am about to release a new major version of eslint-plugin-html and it will not export processors anymore, so this won't work anymore. Of course if you don't change your eslint-plugin-html dependency version everything will be fine, but I don't plan to maintain the v1, and the v2 has long awaited features like the eslint --fix support, which might interest you.

My plugin isn't exposing processors anymore because the current eslint system is too limited (e.i.: doesn't support --fix), and I wanted users to be able to configure the html file extensions they want (most of my plugin PR was about adding new file extensions). Instead, it patches some ESLint functions as soon as it is required. It seems scarry but it already did it from the beginning and it worked correctly since then.

So one solution would be to simply require("eslint-plugin-html"); in your plugin and that's it. .vue files are already considered as HTML by default, but if you want to override the default to only lint .vue files, you can add the following setting in eslint-config-vue:

    "settings": {
        "html/html-extensions": [".vue"],
        "html/xml-extensions": []
    }

See documentation and changelog. I released the v2 as a beta tag, so you can try it with npm i eslint-plugin-html@beta.

Let me know if you have any concern about those changes.

@znck znck added the bug label Jan 17, 2017
michalsnik pushed a commit that referenced this issue Jul 11, 2018
* Add Vue.extend support, add missing info about Vue.mixin check in readme

* Docs: fixes wording in docs (#372)

* Fix: fix script-indent to prevent removing <script> tag (fixes #367) (#374)

*  [Update] Make `vue/max-attributes-per-line` fixable (#380)

* [Update] Make `vue/max-attributes-per-line` fixable

* [fix] bug and style

* [fix] Switch indent calculation method with node and attribute

* [fix] don't handle indentation

* [add] autofix test max-attributes-per-line.js

* Update: make `vue/order-in-components` fixable (#381)

* [Update] Make `vue/order-in-components` fixable

This Commit makes `vue/order-in-components` fixable.
In case of `The "A" property should be above the "B" property` error, autofix will move A before B

* [fix] fail test at eslint@3.18.0

* [fix] If there is a possibility of a side effect, don't autofix

* [fix] failed test at node v4

* [update] use Traverser

* [fix] failed test eslint@3.18.0

* [fix] I used `output: null` to specify "not fix"

* Fix: no-async-in-computed-properties crash (fixes #390)

* Fix: valid-v-on false positive (fixes #351)

* Fix: indent rules false positive (fixes #375)

* [New] Add `prop-name-casing`

* fix message and category

* fix category

* fix test message

* Set category to undefined

* Add more tests and fix edge case scenario

* attribute order linting

* updating docs, tests and category

*  [New] Add rule `vue/no-use-v-if-with-v-for` (#2)

* [fix] `meta.docs.description` should not end with `.`  consistent-docs-description

* [fix] lint error caused by merging the master for conflict resolution

* [fix] That `vue/attributes-order` got duplicated when merging README

* [fixed] document `correct` and `incorrect` the contrary stated

* [fixed] error message
doug-wade pushed a commit to doug-wade/eslint-plugin-vue that referenced this issue Apr 17, 2022
Use dataframes instead of dictionaries to perform ID lookup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants