Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option to specify tags to ignore vue/no-deprecated-slot-attribute #2314

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

kazuma0129
Copy link
Contributor

@kazuma0129 kazuma0129 commented Nov 14, 2023

closes: #2313

I have not yet updated the documentation for this rule. If the content of this PR and issue is accepted, I will start working on those.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess this makes sense. I have some comments though. Thanks for your contribution!

lib/rules/no-deprecated-slot-attribute.js Outdated Show resolved Hide resolved
lib/rules/syntaxes/slot-attribute.js Outdated Show resolved Hide resolved
lib/rules/syntaxes/slot-attribute.js Outdated Show resolved Hide resolved
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@kazuma0129
Copy link
Contributor Author

@FloEdelmann @ota-meshi
How about this one? Let me know if there is any work that needs to be done.

@ota-meshi
Copy link
Member

I need to review, merge and release this PR, but I don't have time to do that now 😓

@kazuma0129
Copy link
Contributor Author

kazuma0129 commented Nov 22, 2023

@ota-meshi Thank you for the reply. If so, it's fine when you have time.🙆‍♂️ Just wanted to check on the status.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me. Could you add documentation for the new option?

@kazuma0129
Copy link
Contributor Author

@ota-meshi
I have updated the documentation. Please check it. f3879f4

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 022afb5 into vuejs:master Nov 29, 2023
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule suggestion: Add new option to specify tags to ignore rules vue/no-deprecated-slot-attribute
3 participants