Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(require-explicit-emits): detect template emits #2350

Merged
merged 6 commits into from Dec 27, 2023
Merged

fix(require-explicit-emits): detect template emits #2350

merged 6 commits into from Dec 27, 2023

Conversation

waynzh
Copy link
Contributor

@waynzh waynzh commented Dec 10, 2023 •
edited

This rule has a similar issue to #2337.
The unused emits in the template were not detected, so this PR fixes that.

FloEdelmann
FloEdelmann requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this! I have a few comments, but they should be all fairly small.

lib/rules/require-explicit-emits.js Outdated Show resolved Hide resolved
lib/rules/require-explicit-emits.js Outdated Show resolved Hide resolved
lib/rules/require-explicit-emits.js Outdated Show resolved Hide resolved
tests/lib/rules/require-explicit-emits.js Outdated Show resolved Hide resolved
tests/lib/rules/require-explicit-emits.js Show resolved Hide resolved
waynzh and others added 5 commits December 16, 2023 15:12
@waynzh @FloEdelmann
Update lib/rules/require-explicit-emits.js
01bc0c6 
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
@waynzh @FloEdelmann
Update lib/rules/require-explicit-emits.js
fcfa95f 
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
@waynzh @FloEdelmann
Update tests/lib/rules/require-explicit-emits.js
62d04c0 
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
@waynzh
refactor: rename variable and format
93eef38
@waynzh
test: add a valid test
41c5269
@waynzh
Copy link
Contributor Author

waynzh commented Dec 16, 2023

@FloEdelmann Thanks for the suggestions! I've made the updates. Please take a look when you have a moment.

FloEdelmann
FloEdelmann approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

ota-meshi
ota-meshi reviewed Dec 27, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit d99f37b into vuejs:master Dec 27, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi left review comments

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waynzh @FloEdelmann @ota-meshi