Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-for-delimiter-style): ignore Punctuator token #2416

Merged
merged 2 commits into from Mar 9, 2024

Conversation

waynzh
Copy link
Contributor

@waynzh waynzh commented Mar 5, 2024

fixes vuejs/vue-eslint-parser#226 (vue-eslint-parser issue!)

Maybe we can simply ignore all 'Punctuator' type token, without the need to specifically declare token.type !== 'Punctuator' || (token.value !== ')' && token.value !== ',')?

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some test cases with v-for="(key, value) in items" and check that the fix does not break them?

@waynzh waynzh requested a review from FloEdelmann March 5, 2024 07:48
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 🙂

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 7c71c48 into vuejs:master Mar 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a bug in the use fix action of v-for-delimiter-style under special syntax
3 participants