Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(require-toggle-inside-transition): check directive #2487

Merged
merged 3 commits into from
Jul 2, 2024
Merged

feat(require-toggle-inside-transition): check directive #2487

merged 3 commits into from
Jul 2, 2024

Conversation

waynzh
Copy link
Contributor

@waynzh waynzh commented Jun 27, 2024

fix #2467

ota-meshi
ota-meshi approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

FloEdelmann
FloEdelmann approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, apart from a minor naming suggestion 🙂

lib/rules/require-toggle-inside-transition.js Outdated Show resolved Hide resolved
lib/rules/require-toggle-inside-transition.js Outdated Show resolved Hide resolved
@ota-meshi ota-meshi merged commit 3ad09ef into vuejs:master Jul 2, 2024
18 checks passed
This was referenced Jul 29, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@waynzh @FloEdelmann @ota-meshi